Not quite sure what the best approach is going to be."Drontburg Coal Mine increases production!" changing this algorithm might increase the amount of generated cargo/passengers and people are already complaining about that. It has an idea for improvement, but I'm not very satisfied with it.Īnyhow. with even ratings station 2 gets some cargo.Īttached is a spreadsheet to experiment a bit with the numbers. With your algorithm given 'amount' 2 and equal ratings, station 2 would get occasionally some cargo from rating 209 and lower, with trunk it has a chance from rating 255 and lower. Those percentages come from an # openttdcoop savegame over ~1 million calls to the MoveGoodsToStation function). Given that the function is called more more often with lower 'amounts' (amount 1: 25%, amount 2: 14%, amount 3: 9%, amount 4: 7%), so they cancel eachother out over time. With trunk's algorithm it would underestimate for the higher 'amounts' but overestimate with lower 'amounts' (<5). With your algorithm/change it would consistently overestimate for any 'amount'. Should we send 'on average' more cargo through than the maximum cargo rating would do in a 1 station case?
Sparr, you're right those numbers are wrong.Īlthough now the 'real' question becomes. This comment was imported from FlySpray:
#OPENTTD STATION RATING PATCH#
So the patch actually breaks the 'best station gets most cargo' behaviour!Īs you can see at the 'total moved' lines the industry rating gets higher in all cases (except a 100% station rating, i.e. Here the second station gets more cargo than the first station even though the first station has a higher rating. Where's the penalty gone? This happens with all ratings 64 and 61 Hmm, so the second station does get more than the first station. With your the patch applied the combined 'rating' would become 90%. station_competition_fix_0001.patch (0.52 KiB).The bug occurs when the second gets 27*(60/2)/100+1=9 goods instead of 27*60/100+1=17, strangely increasing its internal post-split wastage from the expected 40% to around 70%.Īttached is a patch that moves the penalty to the correct location. The first then actually gets 7380/100+1=59 goods. 100 goods are split between them with the first being assigned (100+1) 80/(80+(60/2))=73 of them and the second the remaining 27. However it remains in effect when the amount of wasted goods are calculated for the second station, which seems like an undesired and unanticipated side effect.īy way of an example, simplified to % instead of internal n/255ths, two stations have ratings of 80% and 60%. It correctly (as documented, but not quite desirably, the subject of another feature request) affects the split of goods available to the two stations. In the current MoveGoodsToStation calculation, the penalty adjustment (effectively dividing the rating in half) to the second highest station rating is applied too broadly.
0 kommentar(er)
